feat: improve gno linter with basic errors support #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
from `testscripts` doc.go: UpdateScripts specifies that if a `cmp` command fails and its second argument refers to a file inside the testscript file, the command will succeed and the testscript file will be updated to reflect the actual content (which could be stdout, stderr or a real file). The content will be quoted with txtar.Quote if needed; a manual change will be needed if it is not unquoted in the script. Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
+ Coverage 55.95% 56.05% +0.10%
==========================================
Files 435 435
Lines 66306 66409 +103
==========================================
+ Hits 37101 37228 +127
+ Misses 26303 26287 -16
+ Partials 2902 2894 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
gfanton
force-pushed
the
feat/gnolint-error
branch
from
0297418
to
5eb43c4
Compare
moul
reviewed
Oct 7, 2023
moul
reviewed
Oct 7, 2023
Signed-off-by: gfanton <[email protected]>
gfanton
changed the title
|
Related with #1215. |
3 tasks
tbruyelle
reviewed
Oct 12, 2023
tbruyelle
reviewed
Oct 12, 2023
thehowl
reviewed
Oct 20, 2023
github-actions
bot
added
the
🧾 package/realm
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
thehowl
reviewed
Oct 23, 2023
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
moul
approved these changes
Dec 7, 2023
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
|
@moul added integration for emacs + vim (Im not sure this is the usual way for the last one, but at last it works) |
thehowl
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've improved the linter by using
RunMemPackagein the same way thatgno testdoes for testing.A direct use case for this PR is to provide a simple and reliable method for editors to integrate
gno linting.(There might be a better way to achieve what I've done, of which I'm not aware)
Below a sample of
gno lintoutput:And here's a brief demo using basic integration with emacs:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description